Proposed API: add PyDict_FromItems() #55
Open
+190
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
reviewed
Dec 5, 2025
Comment on lines
+122
to
+123
| INADA-san wrote that most users either overestimate its effectiveness or don't | ||
| fully understand how it operates. |
Contributor
There was a problem hiding this comment.
Doesn't this apply to some other proposals as well?
How do the other functions behave if input contains duplicate keys?
Contributor
Author
There was a problem hiding this comment.
Doesn't this apply to some other proposals as well?
I don't know, I don't want to speak for @methane.
How do the other functions behave if input contains duplicate keys?
So far, all proposed functions allocates N items even if there are duplicate keys.
encukou
reviewed
Dec 5, 2025
Comment on lines
+165
to
+166
| Such function lacks an *override* argument to decide how to deal with | ||
| overridden keys on updating an existing dictionary. |
Contributor
There was a problem hiding this comment.
So if we add an override argument, there's no downside?
Contributor
Author
There was a problem hiding this comment.
Well, I prefer PyDict_FromItems() to create a dictionary :-) PyDict_FromItems() has less parameters and so is simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.